Move Select's toggle button padding to its children elements #1777
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how padding is handled in the
Select
's toggle button, so that instead of having a surrounding padding in the button itself, we replace it with the corresponding padding to its two children.This is important because the first children truncates its content via tailwind's
truncate
. This class, among other things, addsoverflow: hidden
, but we want to allow content to overflow as long as it doesn't grow outside of the button limits.Before:
select-button-padding-before-2024-11-13_15.06.53.mp4
After:
select-button-padding-after-2024-11-13_15.06.10.mp4
Visually, there should be no changes, but the element with the
truncate
class now spans to the button limits, making its behavior more intuitive.Note
The motivation for this change is described in this thread hypothesis/lms#6820 (comment)