Minify production build of patterns.hypothes.is website #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
commented
Nov 29, 2024
| @echo "make sure Make sure that the formatter, linter, tests, etc all pass" | ||
| @echo "make clean Delete development artefacts (cached files, " | ||
| @echo " dependencies, etc)" | ||
| @echo "make test Run the unit tests once" |
There was a problem hiding this comment.
I sorted the entries after make help alphabetically to make it easier to figure out where to slot any new entries in.
robertknight
commented
Nov 29, 2024
| @git archive --format=tar.gz HEAD | docker build -t hypothesis/frontend-shared:latest - | ||
|
|
||
| # Run Docker container. Publish to port 5002 on the host to avoid a conflict | ||
| # with other Hypothesis projects. |
There was a problem hiding this comment.
h's WebSocket server uses port 5001.
acelaya
approved these changes
Dec 2, 2024
|
I think |
robertknight
force-pushed
the
minify-prod-pattern-lib-build
branch
from
10ade1b to
be09ae8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 68 68
Lines 1234 1234
Branches 468 468
=========================================
Hits 1234 1234 ☔ View full report in Codecov by Sentry. |
The changes to rollup.config.js were copied from the hypothesis/client repo.
This enables testing the website locally as follows: 1. Run `make docker` 2. Run `make run-docker` 3. Navigate to http://localhost:5002
robertknight
force-pushed
the
minify-prod-pattern-lib-build
branch
from
be09ae8 to
5168a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dockerandrun-dockermake targets to facilitate local testing of the Docker buildTesting:
make dockermake run-docker