Upgrade tailwindcss to v3.1.2 #443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version provides more types but required some affordances.
lyzadanger
commented
Jun 10, 2022
| @@ -2,7 +2,7 @@ import plugin from 'tailwindcss/plugin.js'; | |||
|
|
|||
| import colors from 'tailwindcss/colors.js'; | |||
|
|
|||
| export default { | |||
| export default /** @type {Partial<import('tailwindcss').Config>} */ ({ | |||
There was a problem hiding this comment.
I think it's early days for tailwindcss's type definitions and I was unable to find an appropriate type for a preset , which is what this is, not a full Config. Without the Partial this will gripe about a missing content property, which is indeed required for configs, but not for presets.
Alternately, might be able to type this using Omit, but I'd rather just do this for now and wait for tailwindcss to add a Preset type or similar.
|
🤦🏻♀️ failing in CI. I'll look next week. |
|
Ah, not my mistake for once: tailwindlabs/tailwindcss#8586 |
|
Converting to draft until there is a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of tailwindcss introduces some additional typing but some
affordances were needed in
tsconfig.jsonand the typing of theshared tailwind preset to accommodate this.