Extract InputRoot component
#827
Conversation
| {...htmlAttributes} | ||
| type={type} | ||
| // @ts-ignore-next |
There was a problem hiding this comment.
Ref-typing purgatory...I should add more comment here but I don't really know what to say.
| return ( | ||
| <input | ||
| <Element | ||
| data-component="InputRoot" |
There was a problem hiding this comment.
In all normal uses of this component this data-component attribute should be overridden. That's by design.
There was a problem hiding this comment.
Just for my own understanding (not related with this PR per se). What's the purpose of data-component when used by consumer code?
There was a problem hiding this comment.
Mostly as a debugging affordance. It's easier to see when inspecting the DOM where elements come from.
| @@ -10,17 +10,4 @@ const contentFn = (Component, props = {}) => { | |||
|
|
|||
| describe('Input', () => { | |||
| testPresentationalComponent(Input, { createContent: contentFn }); | |||
|
|
|||
| it('should warn in console if accessibility attributes are missing', () => { | |||
There was a problem hiding this comment.
This is now the responsibility of InputRoot
Create a new `InputRoot` component. This generalized component, not part of the public API, can apply consistent design patterns to various input element types.
lyzadanger
force-pushed
the
input-root
branch
from
ef929b8 to
8160c6c
Compare
Codecov Report
@@ Coverage Diff @@
## main #827 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 56 57 +1
Lines 682 686 +4
Branches 240 241 +1
=========================================
+ Hits 682 686 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This PR establishes a root component for textual input elements. The purpose of this is to be able to share design patterns and behavior across those input elements. I'm terming this a "Root" element, as distinct from a "Base" element, because it is private to the package. Early days here; I want to feel this out.
Expect to see a
Selectcomponent based on this imminently. ATextAreacomponent is probably not far off, either, but doesn't have as immediate of a need asSelect.There should be no visible or behavioral changes to the existing
Inputcomponent. You can verify that on the Input pattern-library page.