Provide more flexibility with headers and padding of Panels #852
Conversation
|
I can't make any sense of the CodeCov fail. Local test coverage is complete. I'll look in the morning with fresh eyes. |
There was a problem hiding this comment.
I think the code coverage issue is legit. It is complaining about this line not being covered.
In order to cover that you need to explicitly provide paddingSize="none" in some test and check that there's no CardContent in that case.
| @@ -21,6 +34,13 @@ type ComponentProps = { | |||
| * this function as an onClick handler | |||
| */ | |||
| onClose?: () => void; | |||
| /** | |||
There was a problem hiding this comment.
Should there be an empty line before this comment?
Oh, yes, it's legit! I got so busy yesterday that I didn't get a chance to circle back to this. |
The weird thing is that locally it does not complain about that. Only if you open the code coverage report you can see that branch is not covered, but in terms of lines, it is reported as covered, which I think it's not correct. |
Yes, that is my general complaint as well. I did check local coverage before pushing the branch. |
Add new props to Panel: * `scrollable`: Panels no longer scroll their content by default * `fullWidthHeader` * `paddingSize`, including a `none` option to turn off padding around content
* Forward the `paddingSize` prop if provided * Set `Panel` to `scrollable`
lyzadanger
force-pushed
the
scrollable-panel-headers
branch
from
2824746 to
2a8e099
Compare
This PR provides a set of additional props for
CardHeader,PanelandModalto give more flexibility in layout styling.These changes will cause a visual change to existing Modals: the border under the modal's header will now extend all the way to the edges of the modal. Existing
Panels are unaffected. Other props introduced here are additive (no changes to existing usage of these components).The first problem this work attempts to solve is to make
Panel/Modalheaders span the full width if there is scrollable content. This is to avoid scroll hint shadows looking funky (see #839).I also ran into a situation recently in which it was necessary to have more control over the way that padding is applied to Panel content.
The broader fix here, so we don't end up in an arms race, is to not force all
Modalcontent to be inPanels (i.e. allow Modals with arbitrary content, not just Panels). I intend to make the next-generationDialogcomponent more flexible in that respect.These changes are documented on the pattern library pages for
CardPanel, andModal.Fixes #839