Deprecate useElementShouldClose, export granular event hooks
#914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate `useElementShouldClose` in favor of updated, granular event hooks, and make new hooks available in package API.
Codecov Report
@@ Coverage Diff @@
## main #914 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 790 790
Branches 284 284
=========================================
Hits 790 790
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It works in WebStorm
|
acelaya
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
useElementShouldClosein favor of updated, granular event hooks, and make new hooks available in package API.Follow up to fixing #900
(Side note: the
@deprecatedkeyword as applied to component functions in the past has triggered my editor to recognize those components (when imported or used) as deprecated, but that isn't the case for this hook function. I hope I ... deprecated it correctly?)