Add focus restoration to Dialog, ModalDialog
#930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyzadanger
force-pushed
the
dialog-restore-focus
branch
from
6175c03 to
3c20b42
Compare
Codecov Report
@@ Coverage Diff @@
## main #930 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 64 +1
Lines 795 807 +12
Branches 287 289 +2
=========================================
+ Hits 795 807 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
acelaya
approved these changes
Mar 22, 2023
| }, | ||
| // We only want to run this effect once when the dialog is mounted. | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| [] |
There was a problem hiding this comment.
Passing restoreFocusEl here should be the same in practice, as the ref object won't change on renders. Maybe we can explicitly add the dependency instead of suppressing the rule, to avoid unexpected future side effects if something else changes?
There was a problem hiding this comment.
Exhaustive dependencies would also require restoreFocus (a prop). I don't want this hook to run again if the restoreFocus prop changes...
lyzadanger
force-pushed
the
dialog-restore-focus
branch
from
3c20b42 to
00afebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds restore-focus support when a
Dialogis closed (unmounted in this case, as Dialogs do not manage state otherwise). This is disabled by default for (i.e. non-modal)Dialogs, but enabled by default forModalDialog.This is consistent with WAI-ARIA behavior guidelines for modal dialogs.
Depends on #929
Part of #77