Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prototype section and page for re-use annotations features #977

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

lyzadanger
Copy link
Contributor

@lyzadanger lyzadanger commented Apr 21, 2023

This PR:

  • Adds a navigation section, route group and place to put pattern-library pages for prototyping UI stuff
  • Brings over a bunch of client Menu component stuff (more on this below)
  • Adds a couple of icons useful for the prototyping examples
  • Adds a page for prototyping some wireframe/low-fidelity UI sketches for the re-use annotations projects

Don't panic at the diff size. Most of this is on account of my bringing over Menu, MenuItem, MenuArrow from the client (and putting them in the prototype area as utility components — this is not a PR to actually add those components to this package). Alas, the current structure of the AnnotationPublishControl is such that it has dependencies on all of these. I agonized a while before bringing these over. But I needed to get some sketch work done, and I needed the annotation-publish interface to be reasonably believable.

Thus, this PR is sort of three chunks:

  1. Add a structure for prototyping in the pattern library: a directory, route, route group
  2. Add some components temporarily (in the prototyping area) to support a specific UI prototyping need
  3. Adding the prototyping page itself and supporting assets

The prototype page itself is loose and is the basis for some discussions next week.

Detail of prototype page:

image

Bring over a few Menu-related components from the `client` app to
support immediate prototyping needs. These were lightly altered to
update imports. These are only for prototyping support purposes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simplified, shortened and adapted variant of the client's AnnotationPublishControl for UI-sketching purposes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not require review; it is only used for UI sketching purposes. It's brought over from the client and lightly adapted (primarily imports).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also no need for review on this one.

Copy link
Contributor Author

@lyzadanger lyzadanger Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will ensure that the prototype directory sticks around if we remove any pages inside of it.

@lyzadanger lyzadanger requested a review from acelaya April 21, 2023 14:01
Copy link
Contributor

@acelaya acelaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@lyzadanger lyzadanger merged commit a0b1e78 into main Apr 21, 2023
@lyzadanger lyzadanger deleted the spike-ui-shared-annotations branch April 21, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants