-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prototype section and page for re-use annotations features #977
Conversation
Bring over a few Menu-related components from the `client` app to support immediate prototyping needs. These were lightly altered to update imports. These are only for prototyping support purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a simplified, shortened and adapted variant of the client's AnnotationPublishControl
for UI-sketching purposes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not require review; it is only used for UI sketching purposes. It's brought over from the client and lightly adapted (primarily imports).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also no need for review on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will ensure that the prototype
directory sticks around if we remove any pages inside of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
This PR:
Menu
component stuff (more on this below)Don't panic at the diff size. Most of this is on account of my bringing over
Menu
,MenuItem
,MenuArrow
from the client (and putting them in the prototype area as utility components — this is not a PR to actually add those components to this package). Alas, the current structure of theAnnotationPublishControl
is such that it has dependencies on all of these. I agonized a while before bringing these over. But I needed to get some sketch work done, and I needed the annotation-publish interface to be reasonably believable.Thus, this PR is sort of three chunks:
The prototype page itself is loose and is the basis for some discussions next week.
Detail of prototype page: