Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't subclass Draft7Validator #17

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

seanh
Copy link
Contributor

@seanh seanh commented Aug 29, 2022

Because doing so is deprecated.

Fixes #16

Because doing so is deprecated.

Fixes #16
Copy link
Member

@marcospri marcospri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It's nice that they provide a clear path forward in the deprecation message itself.

@seanh seanh merged commit 4b8d4c1 into main Aug 31, 2022
@seanh seanh deleted the dont-subclass-Draft7Validator branch August 31, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't subclass Draft7Validator
2 participants