Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon missing next to group name on web app #5656

Closed
dwhly opened this issue Jul 16, 2019 · 1 comment · Fixed by #5662
Closed

Icon missing next to group name on web app #5656

dwhly opened this issue Jul 16, 2019 · 1 comment · Fixed by #5662
Labels
activity page bug

Comments

@dwhly
Copy link
Member

dwhly commented Jul 16, 2019

Steps to reproduce

  1. Go to web app (https://hypothes.is/users/dwhly)
  2. Open an annotation card

Expected behaviour

There should be an icon next to the group name

Actual behaviour

There is no icon, the interface shows "In Public" (for instance)

Browser/system information

Chrome

Additional details

Screen Shot 2019-07-16 at 7 20 40 AM
@robertknight
Copy link
Member

There is an SVG icon there in the DOM tree, but it isn't being rendered. The icon hasn't been changed at all recently, and we haven't done any work on h recently either. This might be a regression due to a dependency update.

@robertknight robertknight mentioned this issue Jul 17, 2019
Closed
robertknight added a commit that referenced this issue Jul 17, 2019
@robertknight
Preserve SVG viewBox when minifying SVGs for production
c030403 
By default svgo removes the `viewBox` attribute of the SVG, which breaks
scaling of the SVG content when rendering.

This caused various icons on the site to render at an incorrect scale.
In some cases this was not very noticeable because the natural size of
the content was close to the scaled size. In other cases the icon failed
to appear at all.

To see the difference, compare:

```
rm build/images/icons/*
NODE_ENV=production gulp build-images
cat build/images/icons/groups.svg
```

Before and after this patch is applied.

Fixes #5656
@robertknight robertknight mentioned this issue Jul 17, 2019
Merged
robertknight added a commit that referenced this issue Jul 18, 2019
@robertknight
Preserve SVG viewBox when minifying SVGs for production
caf5363 
By default svgo removes the `viewBox` attribute of the SVG, which breaks
scaling of the SVG content when rendering.

This caused various icons on the site to render at an incorrect scale.
In some cases this was not very noticeable because the natural size of
the content was close to the scaled size. In other cases the icon failed
to appear at all.

To see the difference, compare:

```
rm build/images/icons/*
NODE_ENV=production gulp build-images
cat build/images/icons/groups.svg
```

Before and after this patch is applied.

Fixes #5656
robertknight added a commit that referenced this issue Jul 22, 2019
@robertknight
Preserve SVG viewBox when minifying SVGs for production
a777a03 
By default svgo removes the `viewBox` attribute of the SVG, which breaks
scaling of the SVG content when rendering.

This caused various icons on the site to render at an incorrect scale.
In some cases this was not very noticeable because the natural size of
the content was close to the scaled size. In other cases the icon failed
to appear at all.

To see the difference, compare:

```
rm build/images/icons/*
NODE_ENV=production gulp build-images
cat build/images/icons/groups.svg
```

Before and after this patch is applied.

Fixes #5656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
activity page bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve SVG viewBox when minifying SVGs for production hypothesis/h
2 participants
@robertknight @dwhly