Enable highlights by default everywhere #2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable highlights by default in the Chrome extension, bookmarklet and embed.
They were already enabled by default in the Chrome extension and
bookmarklet so this only changes the embed.
Highlights are turned on by default in annotator/host.coffee if no
showHighlights option is found.
The extension and bookmarklet no longer need to set showHighlights: true as
this is now the default. The embed (which was not setting showHighlights: true
and so was getting the default setting of false) will now get the new default
setting of true.
For people embedding h into their own pages, they can turn off highlights by
default by including:
<script>
window.hypothesisConfig=function(){return{showHighlights:false}};
</script>
|
Note the embed instructions on the hypothes.is front page need updating when this is deployed. |
Although I'm guessing that you can take care of this with #2740? |
|
LGTM. |
nickstenning
added a commit
that referenced
this pull request
Nov 25, 2015
…t-behavior-of-the-embed-to-highlights-on-by-default Enable highlights by default everywhere
nickstenning
deleted the
trello-177-change-the-default-behavior-of-the-embed-to-highlights-on-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable highlights by default in the Chrome extension, bookmarklet and embed.
They were already enabled by default in the Chrome extension and
bookmarklet so this only changes the embed.
Highlights are turned on by default in annotator/host.coffee if no
showHighlights option is found.
The extension and bookmarklet no longer need to set showHighlights: true as
this is now the default. The embed (which was not setting showHighlights: true
and so was getting the default setting of false) will now get the new default
setting of true.
For people embedding h into their own pages, they can turn off highlights by
default by including:
fixes #2695