Don't test that JWT's issued in future are invalid #4678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove two tests that JWT's whose `iat` value claims that they were issued in the future fail validation. These two tests fail on newer versions of PyJWT: #4672 This is because PyJWT no longer raises an exception for future `iat` times: jpadilla/pyjwt#190 PyJWT removed this validation because: - Clock skew can cause one party to generate `iat` times a few seconds or minutes ahead of another's current time - The JWT spec (RFC 7519) doesn't say that a JWT with a future `iat` should be considered invalid, these JWTs are valid - Other JWT libraries don't do this check
Merged
Codecov Report
@@ Coverage Diff @@
## master #4678 +/- ##
==========================================
- Coverage 96.56% 96.54% -0.02%
==========================================
Files 367 367
Lines 20523 20517 -6
Branches 1165 1165
==========================================
- Hits 19818 19809 -9
- Misses 599 601 +2
- Partials 106 107 +1
Continue to review full report at Codecov.
|
robertknight
approved these changes
Nov 7, 2017
Yup, this seems reasonable. I had a concern about whether there was some way to get long-lived tokens past our checks with this, but those are based on the |
|
wow that pyjwt lib issue is from me like two years ago. small world |
|
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove two tests that JWT's whose
iatvalue claims that they wereissued in the future fail validation.
These two tests fail on newer versions of PyJWT:
#4672
This is because PyJWT no longer raises an exception for future
iattimes:
jpadilla/pyjwt#190
PyJWT removed this validation because:
Clock skew can cause one party to generate
iattimes a few secondsor minutes ahead of another's current time
The JWT spec (RFC 7519) doesn't say that a JWT with a future
iatshould be considered invalid, these JWTs are valid
Other JWT libraries don't do this check