Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify some code #8990

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Simplify some code #8990

merged 1 commit into from
Oct 8, 2024

Conversation

seanh
Copy link
Contributor

@seanh seanh commented Oct 2, 2024

For open groups the group's home page shows the group's creator as its
only member (or none if the group has no creator), whereas for other
types of group it shows the group's list of members.

The page does not show "moderators". It only ever shows a list of
"members" (which may be the group's list of members or may be just the
creator depending on the group type).

It looks like there may have once been an intention to have a list of
group moderators and to show that on the home pages of open groups, but
that never came to pass.

Refactor this code to make the actual current behaviour clearer.

For open groups the group's home page shows the group's creator as its
only member (or none if the group has no creator), whereas for other
types of group it shows the group's list of members.

The page does not show "moderators". It only ever shows a list of
"members" (which may be the group's list of members or may be just the
creator depending on the group type).

It looks like there may have once been an intention to have a list of
group moderators and to show that on the home pages of open groups, but
that never came to pass.

Refactor this code to make the actual current behaviour clearer.
Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any planned changes to this as part of adding new roles or supporting multiple moderators / admins in open groups?

@seanh
Copy link
Contributor Author

seanh commented Oct 8, 2024

Are there any planned changes to this as part of adding new roles or supporting multiple moderators / admins in open groups?

No planned changes to this as part of the current project. In the longer-term I believe there are some changes planned but don't have details. Slack thread

@seanh seanh merged commit f876f2d into main Oct 8, 2024
9 checks passed
@seanh seanh deleted the simplify branch October 8, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants