Add explicit height to student select drop-down #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `h-touch-minimum` class is already applied by the `Select` component but it shouldn't be. Add it redundantly here so it may be removed from the shared component, which shouldn't set a height.
acelaya
approved these changes
Feb 10, 2023
robertknight
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a miscalculation when I created the
Selectshared component last week. It was based on this specific select interface (student drop-down) and I carried over theh-touch-minimumclass (this sets the height of the<select>to 44px). The shared component itself shouldn't set an explicit height.Add the class here to the passed
classesso that it can be removed from the shared component.