Allow optional attributes to be entirely absent from HubSpot #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
force-pushed
the
fix-mapping-optional
branch
from
18c0cd5 to
27492af
Compare
marcospri
commented
Jan 2, 2024
| @@ -338,7 +338,7 @@ def _get_objects(cls, accessor, fields: Iterable[Field]): | |||
| def _map_item(cls, item, fields: Iterable[Field]): | |||
| result = {} | |||
| for field in fields: | |||
| value = item.properties[field.hs_field] or None | |||
| value = item.properties.get(field.hs_field) or None | |||
There was a problem hiding this comment.
Not equivalent to just the get. The or here coerces falsy values (0, None, '') all to None. The tests expect this behaviour.
acelaya
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://hypothesis.sentry.io/issues/4788397766/?environment=prod&project=4504163606790144&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=14d&stream_index=0