Combine each group of 3 consecutive segments in the raw transcript #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segments in typical YouTube transcripts are very short. Grouping them can improve readability, at the cost of making it less precise which part of the transcript corresponds to the current video position. As an initial iteration of grouping, just combine every 3 segments together. Ideally it might be nice to have segments be tidy linguistic units such as sentences, but auto-generated YouTube transcripts often do not contain the information to do this. Part of #955.
Add right padding to prevent buckets from the client's bucket bar overlapping the text, and justify to avoid ragged right edges in multi-line segments.
lyzadanger
approved these changes
Jun 20, 2023
| 'text-stone-800': isCurrent, | ||
| })} | ||
| className={classnames( | ||
| 'grow text-justify peer-hover:text-stone-900', |
There was a problem hiding this comment.
I have a task in #953 to do styling work around the buckets: that's still an open task. This is fine for now, however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Segments in typical YouTube transcripts are very short. Grouping them can improve readability, at the cost of making it less precise which part of the transcript corresponds to the current video position. As an initial iteration of grouping, just combine every 3 segments together.
Ideally it might be nice to have segments be tidy linguistic units such as sentences, but auto-generated YouTube transcripts often do not contain the information to do this.
I also adjusted the layout to justify text and add padding to segments to avoid them being covered by buckets from the client's bucket bar.
Part of #955.
Before:
After: