Add external_link_mode option to open links in a new tab #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-betts
force-pushed
the
test-coverage
branch
from
310a235 to
1a83cc0
Compare
jon-betts
force-pushed
the
link-opening-options
branch
from
eb1e4be to
4eaeaca
Compare
jon-betts
force-pushed
the
link-opening-options
branch
from
4eaeaca to
8c8538f
Compare
jon-betts
commented
Sep 23, 2020
| @@ -111,5 +111,7 @@ | |||
| var embed_script = document.createElement("script"); | |||
| embed_script.src = "{{ h_embed_url }}"; | |||
| document.head.appendChild(embed_script); | |||
|
|
|||
| setupExternalLinkHandler({{external_link_mode(env) | tojson}}); | |||
There was a problem hiding this comment.
I'd copy pasted the code that actually does the work for this above from Via ages ago. We just need to turn it on.
The tojson here will convert our python string into a well formatted javascript string, and prevents any nonsense from leaking out.
seanh
approved these changes
Sep 24, 2020
This was referenced May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to set an option and have links open in a new tab. For: hypothesis/via#259
Testing
Negative case:
make devPositive case:
make dev