This repository has been archived by the owner on Mar 2, 2021. It is now read-only.
Added extended network configuration and tests #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI seems to be failing due to the pry-byebug gem being incompatible with the ruby version in the docker image. If I remove the gem docker build does not fail and the tests pass. |
|
any update? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to configure network interfaces via device-init.yaml. Extended configuration includes setting a static IP address, netmask, gateway dns-nameservers, and wifi config. Refactored the current wifi configuration option to use the same code as the new network configuration. It should be considered to remove the old wifi configuration option as it is also possible to configure wifi via the new network configuration option.
Added tests for the new functionality.
This still needs documentation which I am going to add soon.
This should solve #6 .