Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish default config file #5672

Merged
merged 6 commits into from
Apr 22, 2024
Merged

polish default config file #5672

merged 6 commits into from
Apr 22, 2024

Conversation

MQ1995
Copy link
Contributor

@MQ1995 MQ1995 commented Apr 21, 2024

I polished the default config file a little, making it prettier by separating it in logical sections, while also adding links to the wiki for each section.

I didn't alter any setting, I only moved them into logical sections, and made the file prettier and more beginner friendly.

I propose this should also be used as the autogenerated config file at installation (the one that pops the yellow warning), though I don't see a separate file for that.

polish default config, making it prettier by separating it in sections, and adding links to the wiki for each section.
No configuration was altered, I only made it prettier and more beginner friendly.
I propose this should also be used as the autogenerated config file at installation.
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also remember to change defaultConfig.hpp

example/hyprland.conf Show resolved Hide resolved
example/hyprland.conf Outdated Show resolved Hide resolved
example/hyprland.conf Outdated Show resolved Hide resolved
example/hyprland.conf Show resolved Hide resolved
example/hyprland.conf Outdated Show resolved Hide resolved
example/hyprland.conf Outdated Show resolved Hide resolved
example/hyprland.conf Show resolved Hide resolved
@MQ1995
Copy link
Contributor Author

MQ1995 commented Apr 21, 2024

also remember to change defaultConfig.hpp

@vaxerski Done, I modified everything as specified. I also modified defaultConfig.hpp

@vaxerski
Copy link
Member

you still are adding empty lines after {

@MQ1995
Copy link
Contributor Author

MQ1995 commented Apr 21, 2024

you still are adding empty lines after {

I see what you mean. I removed all of them.
They were just for legibility on my IDE, but it's fine without them too.
It should be fine now.

vaxerski
vaxerski previously approved these changes Apr 21, 2024
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@MQ1995
Copy link
Contributor Author

MQ1995 commented Apr 22, 2024

Sorry, my bad.
Fixed the string terminator.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski vaxerski merged commit e1644e9 into hyprwm:main Apr 22, 2024
7 of 9 checks passed
fred21O4 pushed a commit to fred21O4/Hyprland that referenced this pull request Apr 22, 2024
* polish default config file

polish default config, making it prettier by separating it in sections, and adding links to the wiki for each section.
No configuration was altered, I only made it prettier and more beginner friendly.
I propose this should also be used as the autogenerated config file at installation.

* update default config according to suggestions

* Update defaultConfig.hpp to match example

* remove some whitespace

* match default config

* restored string terminator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants