-
-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
socket2: fix events being reordered #5955
Conversation
why are you listening for incoming events? nothing should be posted to socket2. |
Idk, it was there before |
Actually i think it's not needed anymore, i'll remove it |
By the way, i think |
9532cbb
to
90f1a9f
Compare
doesn't really matter that much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks
Describe your PR, what does it fix/add?
fixes socket2 events being reordered due to std::thread racing with other threads in
postEvent
while pushing multiple events.drops connections that have too many (64) queued events
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
no
Is it ready for merging, or does it need work?
ready