Add option to disable window direction monitor fallback #6182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-Briel-Deal
pushed a commit
to The-Briel-Deal/Hyprland
that referenced
this pull request
May 25, 2024
…prwm#6182) * add monitor fallback option * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Adds an option to disable monitor fallback when focusing or moving a window in a direction. A value of
0will disable moving to an adjacent monitor when focusing/moving a window over the edge of a monitor. A value of1(default) will keep behavior as it is now.With
window_direction_monitor_fallback = 0:movefocus lwill do nothing if the focused window is on the left edge of the monitor (or focus the next window on the workspace depending onno_focus_fallback)movewindow lwill do nothing if the focused window is already on the left edge of the monitorIs there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
This was a feature request for my plugin (shezdy/hyprsplit#20), but I think it makes sense to implement it here.
I don't think the name
window_direction_monitor_fallbackis ideal but I can't think of anything better so please suggest a better name if you have one.Is it ready for merging, or does it need work?
ready, needs wiki mr