workspaces: don't try to reopen special workspaces #6802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Jul 7, 2024
VirtCode
force-pushed
the
special-workspace-reopen
branch
from
73720c4
to
203b2da
Compare
DawfukFR
pushed a commit
to DawfukFR/Hyprland
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Currently, if a special workspace is set whilst already being open, the special workspace is put in a weird state where it is open, but not shown (possibly due to the fade-in and fade-out animations being ran concurrently).
This bug was bothering me for quite some time, but never came around to look into it. In my case it often happens because I have windowrules along these lines:
This meant that when I tried to open such a window with the workspace already being open, it would enter this weird invisible state. Of course, this state could be overcome by just closing and reopening the special workspace, but it was annoying nonetheless.
The implemented fix is simple, just don't do anything if the workspace is already shown.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No
Is it ready for merging, or does it need work?
Yes