Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xwayland black window bug after losing focus #6966

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

UjinT34
Copy link
Contributor

@UjinT34 UjinT34 commented Jul 21, 2024

Describe your PR, what does it fix/add?

Sets and removes the withdrawn state for fullscreen xwayland apps. Fixes #6375

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Might mess with withdrawn state from handleUnmapNotify.

Is it ready for merging, or does it need work?

Ready

@BluewyDiamond
Copy link

in my case switching from xwayland fullscreen game back to steam and then back to the game will result the game going black, switching to wayland window and then back to the xwayland fullscreen game works fine

@BluewyDiamond
Copy link

i've retried it just to be sure and now the xwayland game does not turn black even if i switch to steam (xwayland window) or in other words it works for me now, not sure what happened when i first tried it where it did turn black

src/xwayland/XWM.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! This is way better

@vaxerski vaxerski merged commit 511e9cc into hyprwm:main Jul 22, 2024
11 checks passed
@turboshark
Copy link

Sorry if this is a dumb question but how do I get this to work? I'm trying to play GTA IV and it still crashes when I switch workspaces. If I try to play my game in windowed mode and use Hyprland fullscreen it works but it has an thin line chopped off the screen at the bottom. I'm using Arch with everything updated in this not in the repo yet?
image

@BluewyDiamond
Copy link

are u using the aur package (hyprland-git)?

@turboshark
Copy link

are u using the aur package (hyprland-git)?

No I'm using upstream, how long do you think it'll take for this to be added to the main Arch repo?

@vaxerski
Copy link
Member

whenever we release 0.42.0 and then a couple days, most likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XWayland game turns black after switching to another XWayland window.
5 participants