-
-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor dispatchers to be beetter #7331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikalco
changed the title
move half da dispatchers to refactor
refactor dispatchers to be beetter
Aug 14, 2024
ikalco
force-pushed
the
refactor_dispatchers_with_errs
branch
from
August 22, 2024 04:07
eab8af3
to
68ab75e
Compare
beeter |
vaxerski
reviewed
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll review the actual errors once I am on my desktop tomorrow
vaxerski
approved these changes
Aug 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the boring ass work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
will fix #7135
allow for better error messages from dispatchers, for hyprctl
also allow them to specify whether to pass the keybind event or not
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
move some keybindManager debug log errors to SDipatchResult error and print them somewhere elseIs it ready for merging, or does it need work?
yea, but review
also sorry for massive pr but its mostly replacing
return;
withreturn {};
orreturn {.success = false, error = "whatever the log above it was"}