Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windowrules: add fullscreenstate field #7466

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

sungyoonc
Copy link
Contributor

@sungyoonc sungyoonc commented Aug 22, 2024

Describe your PR, what does it fix/add?

Add fullscreenstate field for window rules v2.

fullscreenstate: [internal] [client] matches windows with specific fullscreen state.

For example

  • fullscreenstate:0 1 matches windows that have internal state of 0 and client state of 1.
  • fullscreenstate:* 2 matches windows that have client state of 2 (internal state can be anything).

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Accompanying wiki MR: hyprwm/hyprland-wiki#757

Is it ready for merging, or does it need work?

Ready for merging.

@sungyoonc sungyoonc changed the title feat: add fullscreenstate window rule feat: add fullscreenstate window rules v2 field Aug 22, 2024
@sungyoonc sungyoonc changed the title feat: add fullscreenstate window rules v2 field windowrules: add fullscreenstate field Aug 22, 2024
@vaxerski
Copy link
Member

why not make "any" a * instead of -1, or allow both?

@sungyoonc
Copy link
Contributor Author

why not make "any" a * instead of -1, or allow both?

Made any a *.

@vaxerski
Copy link
Member

with this we can nuke fullscreen in a future mr

@vaxerski vaxerski merged commit 688fe5c into hyprwm:main Aug 23, 2024
10 checks passed
@sungyoonc sungyoonc deleted the feat-fullscreen-state-rule branch August 23, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants