Modified the movefocus
dispatcher to prioritize focus change within groups.
#8601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
It modifies the
movefocus
dispatcher logic to switch directional focus within groups first:movefocus l/r
can now be used to switch tabs within the Groupmovefocus u/d
is pressed, then the usual directional focus logic applies.In other words, a sideways directional focus change is prioritized within groups first.
How I think it benefits users?
movefocus
dispatcher to be followed within groups as it does in other window managers. I felt locked out of tabbed groups and never really used them because of this.changegroupactive
along withmovefocus
as they require separate keybinds which do not conflict.i3
)mod h/j/k/l
withmovefocus l/r/u/d
is intuitive for groups too.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I haven't found any bugs. It works as per the logic described above.
Is it ready for merging, or does it need work?
I have tried with all kinds of group orientations and it works good. It is a single block of 13 lines and could be merged as-is. :)