-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pseudo field for windowrulev2 #8623
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm. I don't like this. Pseudo is... technically layout-specific. Maybe we should add some method to define layout-specific windowrules? like layout:...
?
Indeed, |
hm, I am unsure how to deal with this... nicely. Considering pseudo is exposed to everything, I'd say let's just keep it the old way for now I guess.. I'll do something in the future with this |
Stupid question/suggestion. Can't you just use window tagging for some of this? Layouts change behavior/do magic stuff based on existence of some window tag(s). Users can tag windows however they want (rules, manually etc) and stuff Just Works[tm]. Just document which tags do what for the layouts. I dunno, just seems like the tag system could lead to some pretty useful/powerful stuff layout wise if the layouts wanted to take advantage. I guess the one downside is tags can't have values, hmmm. You'd still have the 'layout specific and possibly colliding' thing either way tho. Although some tags might make sense to share between layouts (all master/stack based layouts could use a 'master' tag on windows to place them into the master stack, etc) |
Describe your PR, what does it fix/add?
As the title says, this adds a "pseudo:" field for windowrulev2.
Is it ready for merging, or does it need work?
It's ready.