window: move size reporting to animation begin callback

[PaideiaDilemma]

Describe your PR, what does it fix/add?

Made so many mistakes in the animation PR...
I removed this from tick when playing around with damage:

// set size and pos if valid, but only if damage policy entire (dont if border for example)
if (validMapped(PWINDOW) && av->m_eDamagePolicy == AVARDAMAGE_ENTIRE && !PWINDOW->isX11OverrideRedirect())
    g_pXWaylandManager->setWindowSize(PWINDOW, PWINDOW->m_vRealSize.goal());

Had the intention to move that to a update callback for the window size, except - well - I didn't.
Worst thing about this is that some xwayland changes probably were only made because this was missing. Sorry for that.
I will go though other size/position related changes since and check if they are redundant tomorrow.

Closes #9269
Closes #9256
Closes #9279

CC @nnyyxxxx wanna verify that it fixes #9256? ✔️

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

atlauncher import window still works ^^

Is it ready for merging, or does it need work?

Ready.

[nnyyxxxx]

sure

[nnyyxxxx]

fixed both issues but has minor visual glitches

[PaideiaDilemma]

wanna post a vid of the gitches?

[nnyyxxxx]

just disregard that, most instant window resizing in hyprland does have visual glitches.

For instance have a browser open alone (very sad) in one workspace and then open a terminal. The browser will have weird behaviour when adjusting. this is probably normal

[nnyyxxxx]

what happened?

[PaideiaDilemma]

I am trying out jujutsu and pushed the wrong bookmark after a rebase. Leaving my main to be in sync with Hyprland main and that seems to autoclose a PR ^^

[nnyyxxxx]

this is finished right?

[PaideiaDilemma]

Ok so in the latest commit i moved most of the sendWindowSize calls to the animation begin update. (Also gets called when animations are disabled)

I think that makes sense because

• the animation begin corresponds to actual visual size changes
• it is easier to maintain

Caveats:

• setValueAndWarp does NOT trigger the animation begin cb. If size updates should still be sent, call it afterwards (like on window drag resizes without animations)
• position updates don't use the same mechanism, but sendWindowSize configures x11 windows with position and size. would be nice to decouple it like the TODO mentions, but idk where and how we want to configure the x11 surface in that case.

sendWindowSize is still manually called in the following places:

• layout/IHyprLayout.cpp in onMouseMove
• events/Windows.cpp in listener_unmanagedSetGeometry for fullscreen with force = true
• Compositor.cpp in setWindowFullscreenState with force = true
• managersXwaylandManager.cpp in activateWindow with force = true
• desktop/Window.cpp in onX11Configure when dragging with force=true
• desktop/Workspace.cpp in forceResportSizesToWindows with force=true

[vaxerski]

39