Fix touch calibration matrix #9553
Open
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rotation transform property is only applied when **no** calibration matrix is set.
nnyyxxxx
reviewed
Mar 6, 2025
Co-authored-by: nyx <nnyyxxxx@protonmail.com>
vaxerski
reviewed
Mar 6, 2025
|
Then it would be better to check if the transform is set in the config, and this means getting rid of the default transform value, only applying it when it's set. Or having a But I personally think that it's redundant, because the only way a device would have a non-default calibration matrix is when it is set by the user. |
|
Now transform works as expected, but only when it's set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
The previous implementation overrides any calibration matrix that is set (like in hwdb), even when
transformis not set in the config. This PR checks if a calibration matrix is set, and would ignore transforms as they'd already be applied. Otherwise, matrices set by transform are used.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
This could also be applied to tablets in
setTabletConfigsbut I haven't tested that.Is it ready for merging, or does it need work?
I believe it is ready.