Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyprconf: templated configuration and event handling #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

trippwill
Copy link
Contributor

I could refactor forever, but decided it's time to get some other eyes on this.

@vaxerski vaxerski requested a review from fufexan October 18, 2022 22:20
@vaxerski
Copy link
Member

no clue wtf this is but pretty cool 👍

I'll let fuffie handle this :^)

@fufexan
Copy link
Member

fufexan commented Oct 19, 2022

Honestly no idea how to review this, I don't know nearly enough python. But if it works for you, I'd say it's good to go.

I'll try to find a python linter to add to the CI. Or perhaps you're aware of some testing tool that we could add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants