Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually register inhibit cookies #14

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

ItsDrike
Copy link
Contributor

I'm not sure if this was intentional or not, but when going over the code of hypridle, I noticed that the inhibit cookies that are created and sending back to dbus aren't actually getting registered, so uninhibit never detects a valid cookie.

Unless this was done intentionally, because the support isn't yet ready or whatever, these cookies should really be getting registered once created.

@vaxerski
Copy link
Member

likely, was done in a hurry

src/core/Hypridle.cpp Outdated Show resolved Hide resolved
src/core/Hypridle.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks bae

@vaxerski vaxerski merged commit 158c52c into hyprwm:main Feb 20, 2024
1 check passed
@ItsDrike ItsDrike deleted the register-inhibit-cookies branch February 20, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants