Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: move to sdbus-cpp2 #96

Merged
merged 6 commits into from
Oct 22, 2024
Merged

core: move to sdbus-cpp2 #96

merged 6 commits into from
Oct 22, 2024

Conversation

vaxerski
Copy link
Member

@vaxerski vaxerski commented Oct 22, 2024

Needs testing

@fufexan ci

@vaxerski vaxerski linked an issue Oct 22, 2024 that may be closed by this pull request
@VirtCode
Copy link

Things like lock_cmd, before_sleep_cmd and after_sleep_cmd dont seem to work anymore. Probably caused by these error messages which are printed:

...
[LOG] wayland done, registering dbus
[WARN] Couldn't connect to logind service ([org.freedesktop.DBus.Error.ServiceUnknown] The name is not activatable)
[LOG] Using dbus path
[WARN] Couldn't retrieve current systemd inhibits ([org.freedesktop.DBus.Error.ServiceUnknown] The name is not activatable)
[TRACE] [core] got poll event
...

main (for reference):

...
[LOG] wayland done, registering dbus
[LOG] Using dbus path /org/freedesktop/login1/session/_33
[TRACE] [core] got poll event
...

Otherwise listeners and their inhibition seems to work (tested with wayland idle inhibitor)

@vaxerski
Copy link
Member Author

@VirtCode try now

@VirtCode
Copy link

VirtCode commented Oct 22, 2024

The connection seems to do something now:

[LOG] wayland done, registering dbus
[LOG] Using dbus path /org/freedesktop/login1/session/_33

However, the before_sleep commands etc. are still not working. Also, the normal listeners don't seem to work anymore. It's also odd that there are no longer any [TRACE] [core] got poll event printed.

@vaxerski
Copy link
Member Author

piss of shit, I'll fix it later, not at pc rn

@vaxerski
Copy link
Member Author

try now

@VirtCode
Copy link

okay great, the lock_cmd etc. work fine now.

However something is broken with dbus inhibits, the locks don't get removed. This is from just pausing and resuming the same video in ff, where as on main it would go from 1 to 0 to 1...:

[LOG] wayland done, registering dbus
[LOG] Using dbus path /org/freedesktop/login1/session/_33
[LOG] ScreenSaver inhibit: true dbus message from  (owner: :1.16) with content video-playing
[LOG] Inhibit locks: 1
[LOG] Cookie 1337 sent
[LOG] ScreenSaver inhibit: true dbus message from  (owner: :1.16) with content video-playing
[LOG] Inhibit locks: 2
[LOG] Cookie 1338 sent
[LOG] ScreenSaver inhibit: true dbus message from  (owner: :1.16) with content video-playing
[LOG] Inhibit locks: 3
[LOG] Cookie 1339 sent
[LOG] ScreenSaver inhibit: true dbus message from  (owner: :1.16) with content video-playing
[LOG] Inhibit locks: 4
[LOG] Cookie 1340 sent
[LOG] ScreenSaver inhibit: true dbus message from  (owner: :1.16) with content video-playing
[LOG] Inhibit locks: 5
[LOG] Cookie 1341 sent

@vaxerski
Copy link
Member Author

@andresilva you committed that feature, any ideas?

src/core/Hypridle.cpp Outdated Show resolved Hide resolved
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
@vaxerski
Copy link
Member Author

thanks bae

@vaxerski vaxerski merged commit 127317f into main Oct 22, 2024
2 checks passed
@VirtCode
Copy link

VirtCode commented Oct 23, 2024

yeah, also saw this yesterday and tried to patch it out locally, but it doesn't fix the issue. Can still reproduce it on 0.1.4.

To me it looks like the second callback (UnInhibit) just never gets called.

@vaxerski
Copy link
Member Author

open a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to build with sdbus-cpp 2.0.0
4 participants