-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: handle scoped keywords if flags are not allowed #49
core: handle scoped keywords if flags are not allowed #49
Conversation
5c7e216
to
06ad22c
Compare
also rebase on main to fix ci |
93a85ea
to
6f57ba5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@vaxerski you forgot to merge. |
no I totally didnt |
After updating my whole system with
I get the config error Instead, I now have to do this:
I believe this commit is responsible. |
hm, right. General keywords should be unscoped. Gimme sec. |
fixed and added a test case: 5df0174 if you want your keyword to only work in global scope (not in categories) prefix it with
|
I was playing with Hyprlang to handle configuration for a project of mine and found out that keywords inside categories are not properly handled (they are simply being ignored).
I added tests to make sure only the correctly scoped keywords are calling the handler.