-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add placeholder_color #35
base: main
Are you sure you want to change the base?
Conversation
placeholder text can already be changed with pango markup |
I feel like this would be a nice abstraction instead of having to do pango markup. I personally had to go through issues to figure it out. (that might be a skill issue on my part but still) |
it's clear in the docs even with a link? |
this could be useful as "authentication failed" doesn't use pango markdown |
I'd prefer configuring the text there and not color |
what about adding one problem with fail placeholder color being inverted, like it is now: |
color change for the outer color = ok, but again I'd prefer a configurable text for fail rather than color |
u mean just use markup like for normal placeholder? |
mhm |
gonna look at it later |
dont think so |
Added placeholder_color configuration option that changes placeholder text color!
Hopefully everything is ok and I can become a more major contributer to Hypr stuff in the future (I got pretty moved by the blogpost).
Honestly the implementation is sketch af though, although it works on all cases I've tested it.