widgets: add onclick feature #653
Conversation
- renderer: move getOrCreateWidgetsFor method declaration to public section
- config: add onclick special config value to label
|
future things to consider:
|
- add CLICKABLE macro for onclick configuration - replace direct onclick assignment with CLICKABLE macro
- ensure pointer is available before setting cursor shape - initialize cursor shape device if not already done
- implement onHover method to manage widget hover states - update cursor shape based on hover status - ensure all outputs are redrawn after state changes
- add setHover and isHovered methods to manage hover state - implement containsPoint method for hit testing - override getBoundingBox in CLabel for accurate positioning - add onHover method in CLabel to change cursor shape
- invoke onHover method with current mouse location
- add getBoundingBox method to calculate the widget's bounding box - implement onHover method to update cursor shape on hover
|
Moved 'containsPoint' to 'IWidget', added a virtual method 'getBoundingBox'. |
- modify cursor shape setting to only apply when onclickCommand is not empty
- Improve hover state tracking for widgets - reduce unnecessary redraw calls by tracking hover changes - remove redundant renderAllOutputs() call
| outputNeedsRedraw = true; | ||
| } | ||
|
|
||
| if (!cursorChanged) { |
| @@ -22,6 +22,9 @@ class CLabel : public IWidget { | |||
| void renderUpdate(); | |||
| void onTimerUpdate(); | |||
| void plantTimer(); | |||
| CBox getBoundingBox() const override; | |||
There was a problem hiding this comment.
style: just virtual, no override.
| @@ -17,6 +18,13 @@ class IWidget { | |||
| static int roundingForBox(const CBox& box, int roundingConfig); | |||
| static int roundingForBorderBox(const CBox& borderBox, int roundingConfig, int thickness); | |||
|
|
|||
| virtual CBox getBoundingBox() const { | |||
There was a problem hiding this comment.
Nit: maybe add a comment, or rename it to make it clear that this has to return Top-left position and size.
There was a problem hiding this comment.
What about getBoundingClientRect?
There was a problem hiding this comment.
posFromHVAlign returns bottom-left positions, while wayland typically uses top-left. So just getBoundingBoxWL would work. getBoundingClientRect is also fine :)
|
works nicely! |
Implement feature requested in #366.