Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Query 35 #51

Closed
5 tasks done
janetzki opened this issue Jun 12, 2019 · 1 comment · Fixed by hyrise/hyrise#1791
Closed
5 tasks done

Optimize Query 35 #51

janetzki opened this issue Jun 12, 2019 · 1 comment · Fixed by hyrise/hyrise#1791
Assignees
@janetzki
Labels
⚡ Performance
Milestone
Sprint 9

Comments

@janetzki
Copy link

janetzki commented Jun 12, 2019 •
edited
Loading

  • Add test a test for SubqueryToJoinRule
  • Try "hacky" optimization only for this query
  • Optimize general pattern if optimizable
  • Could we use this to optimize TPC-H 19?
  • Get performance numbers
  • Do not optimize if no other rule can use it
@janetzki janetzki self-assigned this Jul 9, 2019
@janetzki
Copy link
Author

janetzki commented Jul 10, 2019 •
edited
Loading

So far, I found two ways for optimization:

janetzki added a commit that referenced this issue Jul 10, 2019
@janetzki
✅ Add test case #51
99e8cff
@janetzki janetzki added this to the Sprint 7 milestone Jul 12, 2019
janetzki added a commit that referenced this issue Jul 12, 2019
@janetzki
🔀 Merge remote-tracking branch 'hrmaster/master' into feature/51_jj_o…
95a2a62 
…ptimize_query_35

 #51
janetzki added a commit that referenced this issue Aug 6, 2019
@janetzki
🚧 Add OrToUnionRule
9a17dc7 
 #51
janetzki added a commit that referenced this issue Aug 7, 2019
@janetzki
✨ Implement simple OrToJoinReformulation
9bc9902 
 #51
@janetzki janetzki modified the milestones: Sprint 7, Sprint 8 Aug 7, 2019
janetzki added a commit that referenced this issue Aug 7, 2019
@janetzki
✅ Add more test cases
73cdbdd 
 #51
janetzki added a commit that referenced this issue Aug 7, 2019
@janetzki
🚧 Add failing test
d040b83 
 #51
janetzki added a commit that referenced this issue Aug 14, 2019
@janetzki
🐛 Fix wrong ColumnIDs
7587361 
 #51
janetzki added a commit that referenced this issue Aug 14, 2019
@janetzki
🐛 Fix wrong ColumnIDs
162a530 
 #51
Co-authored-by: mrks <markus@dreseler.de>
janetzki added a commit that referenced this issue Aug 14, 2019
@janetzki
✅ Add test queries
3354b4f 
 #51
janetzki added a commit that referenced this issue Aug 14, 2019
@janetzki
✅ Change test for missing feature to NoRewrite test
491f5ab 
 #51
janetzki added a commit that referenced this issue Aug 14, 2019
@janetzki
🔥 Remove dead code
0e2ee5c 
 #51
janetzki added a commit that referenced this issue Aug 14, 2019
@janetzki
🎨 Clean up the code
faf09ed 
 #51
janetzki added a commit that referenced this issue Aug 14, 2019
@janetzki
🚨 Format the code
b2f3341 
 #51
@janetzki janetzki mentioned this issue Aug 14, 2019
Merged
janetzki added a commit that referenced this issue Aug 15, 2019
@janetzki
👌 Address review comments
a05c1a6 
 #51
janetzki added a commit that referenced this issue Aug 15, 2019
@janetzki
🔀 Merge with master
ddce3f2 
 #51
janetzki added a commit that referenced this issue Aug 15, 2019
@janetzki
⬆️ Update submodule
87358d1 
 #51
janetzki added a commit that referenced this issue Aug 16, 2019
@janetzki
⬆️ Update submodule
375175f 
 #51
janetzki added a commit that referenced this issue Aug 16, 2019
@janetzki
✨ Add reformulation of 3 or more predicate expressions
c83e1ae 
 #51
janetzki added a commit that referenced this issue Aug 16, 2019
@janetzki
🚚 Rename OrToUnionRule to DisjunctionToUnionRule
2326ede 
 #51
janetzki added a commit that referenced this issue Aug 16, 2019
@janetzki
🚨 Format the code
a0c483d 
 #51
janetzki added a commit that referenced this issue Aug 16, 2019
@janetzki
🔥 Remove complex test case for TPC-DS 35
fa0c16a 
 #51
janetzki added a commit that referenced this issue Aug 28, 2019
@janetzki
♻️ Mark methods as private
3b41796 
 #51
@janetzki janetzki modified the milestones: Sprint 8, Sprint 9 Aug 28, 2019
janetzki added a commit that referenced this issue Aug 28, 2019
@janetzki
✅ Fix test query to have an output
8bf4a83 
 #51
janetzki added a commit that referenced this issue Aug 28, 2019
@janetzki
🔥 Remove JoinGraphBuilder::_parse_union()
1d4a14b 
 #51
janetzki added a commit that referenced this issue Aug 28, 2019
@janetzki
🎨 Move test down
3ef44a7 
 #51
janetzki added a commit that referenced this issue Aug 30, 2019
@janetzki
⚡ Run optimization recursively to not touch the same node twice
547b31e 
 #51
janetzki added a commit that referenced this issue Sep 3, 2019
@janetzki
🚑 Execute rule only for conjunctions in the first run
26837d8 
 #51
janetzki added a commit that referenced this issue Sep 3, 2019
@janetzki
🚨 Run the formatter
3111d0c 
 #51
janetzki added a commit that referenced this issue Sep 4, 2019
@janetzki
📌 Reset submodule version to avoid weird merge conflict
eb98ab8 
 #51
janetzki added a commit that referenced this issue Sep 4, 2019
@janetzki
📌 Update submodule
daa0876 
 #51
janetzki added a commit that referenced this issue Sep 4, 2019
@janetzki
💡 Add comment
d2e7d86 
 #51
janetzki added a commit that referenced this issue Sep 4, 2019
@janetzki
🚧 Add PredicateMergeRule
79fa9e1 
 #51
janetzki added a commit that referenced this issue Sep 5, 2019
@janetzki
🚧 Reuse lqp_subplan_to_boolean_expression() to merge LQP to a predica…
91bb569 
…te expression

 #51
janetzki added a commit that referenced this issue Sep 5, 2019
@janetzki
✅ Fix failing tests
1e77722 
 #51
janetzki added a commit that referenced this issue Sep 9, 2019
@janetzki
🐛 Fix UNION merge
0c12979 
 #51
janetzki added a commit that referenced this issue Sep 9, 2019
@janetzki
✨ Activate PredicateMergeRule
741bee7 
 #51
janetzki added a commit that referenced this issue Sep 9, 2019
@janetzki
🎨 Run the formatter
5c1bc9e 
 #51
janetzki added a commit that referenced this issue Sep 9, 2019
@janetzki
🐛 Fix predicate merge
7ee3077 
 #51
janetzki added a commit that referenced this issue Sep 9, 2019
@janetzki
🎨 Run the formatter
febe20b 
 #51
janetzki added a commit that referenced this issue Sep 9, 2019
@janetzki
⚡ Do not merge simple predicate chains
8bc325a 
 #51
janetzki added a commit that referenced this issue Sep 9, 2019
@janetzki
♻️ Refactor tests
815fed2 
 #51
janetzki added a commit that referenced this issue Sep 9, 2019
@janetzki
⚡ Implement optimization heuristic and refactor
2e4e27e 
 #51
janetzki added a commit that referenced this issue Sep 9, 2019
@janetzki
⚡ Adjust heuristic
69c189e 
 #51
janetzki added a commit that referenced this issue Sep 10, 2019
@janetzki
🐛 Add missing statement and refactor
c2c4a6f 
 #51
janetzki added a commit that referenced this issue Sep 10, 2019
@janetzki
🎨 Run the formatter
8a50ed1 
 #51
janetzki added a commit that referenced this issue Sep 10, 2019
@janetzki
♻️ Refactor
4d9a7e3 
 #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janetzki janetzki

Labels
⚡ Performance
Projects
None yet
Milestone
Sprint 9
Development

Successfully merging a pull request may close this issue.

Reformulate OR to UNION hyrise-mp/hyrise
1 participant
@janetzki