-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hc 279 Remove deprecated HySDS code #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just curious though, have you tried building a PCM container with these changes to make sure it didn't break anything?
@mcayanan havent tested it yet, whats the best way to test it? |
On the nisar ci machine, you'll probably need to deploy the container builder update on there and run those commands I linked you to in order to build the PCM container using your changes. When deploying the container builder update on nisar ci, be sure to back up the existing copy that's on there in case there's a bug so you can revert back to it. I don't know if there's an easier way. @pymonger ? |
@mcayanan @pymonger was able to test by cloning
i used branch
i also updated the jenkins build script to point to the new
|
@DustinKLo I might be missing something, but do you know why you were getting those 404 errors when building a job? |
it's because in
|
@mcayanan i re-ran the jenkins job and it's not printing a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for testing this.
https://hysds-core.atlassian.net/browse/HC-279