Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved performance by eliminating String creation by utilizing the original &str slice. #31

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

ChanTsune
Copy link
Contributor

Hi @hyunsik

Thank you for developing such a great crate!

I wanted to contribute to this crate in any way I could, so I made some changes to improve performance.

This change also helps support no_std in issue #3

eliminate `String` creation by utilizing the original &str slice
Copy link
Owner

@hyunsik hyunsik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks great to me. Thank you for your contribution.

@hyunsik hyunsik merged commit 8dd9145 into hyunsik:master Aug 23, 2023
1 check passed
@ChanTsune ChanTsune deleted the feature/performance-improvement branch August 23, 2023 23:31
@ChanTsune
Copy link
Contributor Author

Thank you for merging.
I am honoured to contribute to your project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants