#269 Minor improvements #270

rajeev-k-tomy · 2022-02-10T06:32:50Z

When the cart billing address is empty, the cart states cart.billing_address must be an empty object {}.
Shipping charge is not shown when "Free shipping" is selected.
Show the "Other Addresses" section if the cart address is a "new" address and the customer possesses addresses in the book.
Guest checkout scenario & billing ≠ shipping: When we save billing address, it will make billing = shipping in the UI perspective. However, in the background, it saves billing address only and the shipping address remains intact.
Translations seems to be missing for the below strings
- Save in address book
- Do you already have an account?
- Login
- Do you want to login?

…ddress save logic corrected

… for saving instead of the code

#263 Address cannot save for FR due to region value issue

rajeev-k-tomy added 3 commits February 10, 2022 12:00

#269 translation fixes;many improvements

ba8d815

reverting proxy setting to demo.hyva store

e2ffa4a

#269 correcting the logic to hide Other Addresses section; shipping a…

71dd1a5

…ddress save logic corrected

rajeev-k-tomy linked an issue Feb 11, 2022 that may be closed by this pull request

Minor improvements needed #269

Closed

rajeev-k-tomy requested a review from wigman February 11, 2022 04:49

#263 [ADDRESS]for conuntries with region code integers, use region_id…

e04cc6d

… for saving instead of the code

wigman approved these changes Feb 11, 2022

View reviewed changes

Merge pull request #271 from hyva-themes/263/france-country-issue

11ab0ad

#263 Address cannot save for FR due to region value issue

rajeev-k-tomy merged commit 1fedb09 into main Feb 11, 2022

rajeev-k-tomy deleted the 269/improvements branch February 11, 2022 11:59

Provide feedback