Feature: Add hyva_react_checkout_config event to be able to alter the checkout config #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ]); | ||
|
|
||
| $this->eventManager->dispatch('hyva_react_checkout_config', ['transport' => $transport]); |
There was a problem hiding this comment.
It is good we pass $checkoutConfig as well. Because there are occasions where we need to pass other data from the $checkoutConfig as well. So that will help to avoid a dependency injection in the observer in order to load it?
There was a problem hiding this comment.
Agree! I've just updated the PR to include it as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently in version 1.1.2 the ability to support shipping methods was added, which is great. For some shipping methods implementations, we need access to configuration items. In the regular Magento checkout, any module can dump any setting into the
window.checkoutConfigconfiguration. The current React checkout only passes thepaymentconfiguration.In this PR, I've added an event that allows developers to extend the checkoutConfig however needed.