[ui-select 0.19.4] prevent losing container element and crashing with exception #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt and crashing [ui-select 0.19.4] Prevent "Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined" when scrolling on dropdown while new search is executed and `container` element doesn't exist for a couple milliseconds (using with newest `ui-select 0.19.4`).
re-initialize on each handler call to prevent losing container element and crashing [ui-select 0.19.4]
|
👍 Looks good in my opinion. Also solves the issue where it wasn't able to refresh at the bottom of the list. |
spajdo
approved these changes
Oct 13, 2016
|
I have this error too. Please merge this request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent "Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined" when scrolling on dropdown while new search is executed and container element doesn't exist for a couple milliseconds while the options are being fetched asynchronically (using with newest ui-select 0.19.4).