Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add mpl_hash, a string to string hash.
uthash
is cumbersome to use as a string to string hash. It requires users to define the hash struct, and manage key and value memory allocations, and it is not good in performance due to fragmented memory allocations.This PR adds
MPL_hash
, a specialized string to string hash utility. It manages key and value memories using a dynamically managed memory slab for better efficiency. The strings are dynamically added but only freed atMPL_hash_free
. To erase a key, simply set that key to valueNULL
.Comparison in usage:
Performance-wise, adding 1 million entries with 1000 unique keys, measured on my workstation using
time
:[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short description
Commit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.