-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array index in form #57
Comments
Instead of index number we could use the molecule file name. |
These would need to be converted back to numbers to comply with haddock3 nomenclature. The hardest part of your idea is to know which parameters would comply with that. Currently, we have a python module that reads and "understands" which parameters are expandable from the configuration file. But we don't have an importable dictionary that would tell which parameters are importable from each haddock3 module. Do you think that's relevant to your needs? Another more profound philosophical discussion is to understand what is better for haddock3: having machinery that interprets which parameters are expandable (as we have now), or manually defining the expandable parameters and building upon them. |
For now the workflow builder determines whether a parameter is expandable (aka array or list like) and tied (eg. second item is configuration for second molecule) to another list based on its name. To reduce duplication it would be great if I could ask haddock3
Yeah, having complex code to interpret a minimal parameter definition or having a complex parameter definition and simple code. Both ways have their pros and cons. |
The molecule file name could be very long making it render poorly in a column. It would be nice to render the unique part of a file name. For example |
Still need to implement index with filename |
If you have many array items is it hard to tell which index each item has. The index is sometimes used to map an item to a molecule with the same index.
It would be nice to see the index in the form for an parameter which is an array.
Implementation suggestion
The text was updated successfully, but these errors were encountered: