-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use molecule filename as index #110
Conversation
✅ Deploy Preview for wonderful-noether-53a9e8 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 61.29% 64.06% +2.77%
==========================================
Files 55 56 +1
Lines 3741 3974 +233
Branches 275 317 +42
==========================================
+ Hits 2293 2546 +253
+ Misses 1444 1426 -18
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…on molecule path Refactored code to do parseMolecules only once. Ran pretier on packages/core/src/molecule/addMoleculeValidation.test.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, very nice!
The only thing I would change in this PR is the location of the molecule ID in the topoaa form. I would either top-outline the left hand column, so that the name of the molecule is at the start of the form, or forego columns altogether and use the ID in a title field.
The reason is that with a large form on the right hand side, as is the case with topoaa, the name of a molecule will show up about half way; in addition, there is no clearly visible separation between the two molecules, which means that the user has to pay close attention when filling out the form which question belongs to which molecule.
E.g. in the example below, "hise" belongs to the first molecule, "segment ID" to the second.
Thanks for reviewing. Good suggestion about position, I moved the index label to the top when the children are an object or array. |
Fixes #57
Fixes #76
TODO
Previous PR #104 was merged prematurly, this PR continues work.
To test:
mdref
nodemdref
expand molecules subform+
button on mol_shape parameteryarn storybook
+ http://localhost:6007/Due to formatting with prettier and
yarn lint --fix
there are changes that are not relevant.