-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI tool #105
Comments
|
Related to i-am-bee#105 Add support for `apiKey` and `http_proxy_url` parameters to various tools. * **DuckDuckGoSearchTool**: - Add `apiKey` and `http_proxy_url` parameters to `DuckDuckGoSearchToolOptions`. - Update `_run` method to use `http_proxy_url` for all requests. - Update `_run` method to include `apiKey` in headers if provided. * **GoogleSearchTool**: - Add `http_proxy_url` parameter to `GoogleSearchToolOptions`. - Update `_run` method to use `http_proxy_url` for all requests. * **OpenMeteoTool**: - Add `http_proxy_url` parameter to `ToolOptions`. - Update `_run` method to use `http_proxy_url` for all requests. - Update `_geocode` method to use `http_proxy_url` for all requests.
The second should be optional. I would allow the user to pass custom overrides for underlying |
I'd be interested to take a look as a first issue within the framework/api. Previously I've been looking at the stack and raising a few issues/PRs I think the request here is to add the API tool into the built in tools (as documented here), similar to how we have google, wikipedia, openMeteo etc. I'm not certain on what then needs to be added/left in the bee-api itself since in general custom tools are found dynamically. For core tools, mostly it just seems to require creating an instance of the tool |
Yes, this issue is about migrating this basic implementation to the framework and making it more robust. After that, we will use this tool instead of the current implementation in the API. This issue is only about the framework part. |
@planetf1 I just assigned you the ticket, feel free to reach out if you have any questions/blockers! |
@mmurad2 thanks I'm making a first-pass at the change. I have implementation code, and just debugging a simple e2e test. |
I've added a first-pass draft PR. There is still more to do, but since I am just learning about the bee framework, it would be great if you could check the nature of the change I'm proposing matches your expectations. I made a few changes from the original code
Tests need more work
There's also improvements to the tool itself - such as how error responses are handled, timeout configuration etc. |
@planetf1 I provided you with feedback a few weeks ago. Are you willing to work on this? |
Hi @Tomas2D thanks for the feedback. I'm not going to be able to spend time on this in the short term, so please do reassign if needed. |
Take the following implementation and add it to the framework.
https://github.com/i-am-bee/bee-api/blob/main/src/runs/execution/tools/api-call-tool.ts#L42C1-L43C1
Are there any blockers or things to consider? @pilartomas, @xjacka
The text was updated successfully, but these errors were encountered: