Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAPI tool to framework #111

Closed
wants to merge 1 commit into from

Conversation

chavan-arvind
Copy link

Related to #105

Add support for apiKey and http_proxy_url parameters to various tools.

  • DuckDuckGoSearchTool:

    • Add apiKey and http_proxy_url parameters to DuckDuckGoSearchToolOptions.
    • Update _run method to use http_proxy_url for all requests.
    • Update _run method to include apiKey in headers if provided.
  • GoogleSearchTool:

    • Add http_proxy_url parameter to GoogleSearchToolOptions.
    • Update _run method to use http_proxy_url for all requests.
  • OpenMeteoTool:

    • Add http_proxy_url parameter to ToolOptions.
    • Update _run method to use http_proxy_url for all requests.
    • Update _geocode method to use http_proxy_url for all requests.

Related to i-am-bee#105

Add support for `apiKey` and `http_proxy_url` parameters to various tools.

* **DuckDuckGoSearchTool**:
  - Add `apiKey` and `http_proxy_url` parameters to `DuckDuckGoSearchToolOptions`.
  - Update `_run` method to use `http_proxy_url` for all requests.
  - Update `_run` method to include `apiKey` in headers if provided.

* **GoogleSearchTool**:
  - Add `http_proxy_url` parameter to `GoogleSearchToolOptions`.
  - Update `_run` method to use `http_proxy_url` for all requests.

* **OpenMeteoTool**:
  - Add `http_proxy_url` parameter to `ToolOptions`.
  - Update `_run` method to use `http_proxy_url` for all requests.
  - Update `_geocode` method to use `http_proxy_url` for all requests.
@chavan-arvind chavan-arvind requested a review from a team as a code owner October 26, 2024 09:28
Copy link
Contributor

@Tomas2D Tomas2D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding support for passing custom request options (RequestInit overrides would be enough).
It is more abstract and allows better extensibility.

@Tomas2D
Copy link
Contributor

Tomas2D commented Oct 26, 2024

I quite don't understand how this PR links to #105. The issue is about creating a new tool and not about updating the existing one.

@Tomas2D
Copy link
Contributor

Tomas2D commented Oct 29, 2024

This PR is unrelated to the mentioned issue. Closing for now.

@Tomas2D Tomas2D closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants