feat!: add python code tool over http #195
Draft
+191
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Keep the existing PythonTool over gRPC for now and add a similar tool to go over HTTP when we switch. * Add tests (written for gRPC but adapted for the new one). * The gRPC/HTTP versions coexist for now while our consumers (e.g. bee-api) make the switch. Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
* Modify the existing PythonTool over gRPC to go over HTTP. * Add tests (written for gRPC but adapted for the new one). * Requires CODE_INTERPRETER_URL env var to point to exposed HTTP port (50081). BREAKING CHANGE: Requires exposed port and updated CODE_INTERPRETER_URL. Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
markstur
force-pushed
the
python_http
branch
from
3650a74 to
0143054
Compare
markstur
changed the title
|
Marking as draft because custom tool will also have to be updated. |
|
You could probably remove some of the grpc dependencies together with this PR -- IIRC we use gRPC in a different part of the codebase, but through a different library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this pull-request address?
Part of: #149
Description
Checklist
yarn lintoryarn lint:fixyarn formatoryarn format:fixyarn test:unityarn test:e2e