Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(instrumentation): assert raw prompt #248

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix(instrumentation): assert raw prompt #248

merged 2 commits into from
Dec 12, 2024

Conversation

GALLLASMILAN
Copy link
Contributor

Closes: i-am-bee/bee-observe#17

Description

I cannot use Object.prototype.hasOwnProperty.call detection in my case, which is used in the hasProp function witch is used in the getProp function.

The custom detection is tested and runs well.

Checklist

  • I have read the contributor guide
  • Linting passes: yarn lint or yarn lint:fix
  • Formatting is applied: yarn format or yarn format:fix
  • Unit tests pass: yarn test:unit
  • E2E tests pass: yarn test:e2e
  • Tests are included
  • Documentation is changed or added
  • Commit messages and PR title follow conventional commits

fix(instrumentation): assert raw prompt
f1398e9 
Signed-off-by: Milan Gallas <Milan.Gallas@ibm.com>
@GALLLASMILAN GALLLASMILAN requested a review from a team as a code owner December 12, 2024 10:54
@GALLLASMILAN GALLLASMILAN requested a review from Tomas2D December 12, 2024 10:54
feat(instrumentation): move condition order
3021031 
Signed-off-by: Milan Gallas <Milan.Gallas@ibm.com>
@GALLLASMILAN GALLLASMILAN merged commit 24546c9 into main Dec 12, 2024
4 checks passed
@GALLLASMILAN GALLLASMILAN deleted the fix-assert-raw-prompt-logic branch December 12, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomas2D Tomas2D Tomas2D approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix: rawPrompt in mlflow
2 participants
@GALLLASMILAN @Tomas2D