Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(memory): add python memory examples and docs #421

Merged
merged 5 commits into from
Feb 27, 2025
Merged

docs(memory): add python memory examples and docs #421

merged 5 commits into from
Feb 27, 2025

Conversation

AngeloDanducci
Copy link
Contributor

@AngeloDanducci AngeloDanducci commented Feb 27, 2025 •
edited
Loading

Which issue(s) does this pull-request address?

Covers part of #336 but does not close it entirely.

Description

add python memory examples and docs

Checklist

  • I have read the contributor guide
  • I have signed off on my commit
  • Linting passes: yarn lint or yarn lint:fix
  • Formatting is applied: yarn format or yarn format:fix
  • Unit tests pass: yarn test:unit
  • E2E tests pass: yarn test:e2e
  • Tests are included
  • Documentation is changed or added
  • Commit messages and PR title follow conventional commits

@AngeloDanducci AngeloDanducci added the python Python related functionality label Feb 27, 2025
@AngeloDanducci AngeloDanducci requested a review from a team as a code owner February 27, 2025 09:56
planetf1
planetf1 requested changes Feb 27, 2025
View reviewed changes
ajbozarth
ajbozarth previously approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise the new examples look LGTM, I tested them locally

@jenna-winkler jenna-winkler added the documentation Improvements or additions to documentation label Feb 27, 2025
@AngeloDanducci
docs(memory): add python memory examples and docs
a921344 
Signed-off-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
@AngeloDanducci
docs(memory): use native python unimplemented error instead of custom
543f108 
Signed-off-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
@AngeloDanducci
docs(memory): remove duplicate links to examples
3103059 
Signed-off-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
@AngeloDanducci
docs(memory): remove printing of objects in base memory example
a7b347d 
Signed-off-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
@AngeloDanducci
docs(memory): rebuild memory docs
e55ac22 
Signed-off-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
@AngeloDanducci AngeloDanducci enabled auto-merge (squash) February 27, 2025 21:08
@AngeloDanducci AngeloDanducci merged commit aa9ebaf into i-am-bee:main Feb 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planetf1 planetf1 planetf1 approved these changes

@ajbozarth ajbozarth ajbozarth approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Python related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AngeloDanducci @planetf1 @ajbozarth @jenna-winkler