Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more GitHub Actions #17

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Add more GitHub Actions #17

merged 6 commits into from
Mar 18, 2024

Conversation

nmenezes0
Copy link
Contributor

@nmenezes0 nmenezes0 commented Mar 15, 2024

Context

More repo set-up - adding checks in GitHub Actions.

Changes proposed in this pull request

  • Adding a check for missing migrations
  • Adding checks for pre-commit hooks which covers code checks (ruff)
  • Adds pre-commit to the dev dependencies so it's actually installed

Changes to formatting in migrations - following actually running ruff.

Guidance to review

Link to JIRA ticket

https://technologyprogramme.atlassian.net/browse/CON-36

Things to check

  • I have added any new ENV vars in all deployed environments and updated the .env.example and .env.test files in the repo

@nmenezes0 nmenezes0 marked this pull request as draft March 15, 2024 15:09
@nmenezes0 nmenezes0 force-pushed the feature/36-github-actions branch from f591ee1 to 1cf6767 Compare March 16, 2024 09:09
@nmenezes0 nmenezes0 marked this pull request as ready for review March 18, 2024 08:22
.github/workflows/check_migrations.yml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@nmenezes0 nmenezes0 force-pushed the feature/36-github-actions branch 2 times, most recently from 6282a4d to 55fa2fa Compare March 18, 2024 09:03
@nmenezes0 nmenezes0 requested a review from duncanjbrown March 18, 2024 09:06
@duncanjbrown
Copy link
Contributor

We get some warnings from the check:

System check identified some issues:

WARNINGS:
?: (staticfiles.W004) The directory '/__w/consultation-analyser/consultation-analyser/node_modules/govuk-frontend/dist/govuk/assets' in the STATICFILES_DIRS setting does not exist.
Operations to perform:
  Apply all migrations: auth, consultations, contenttypes, sessions
Running migrations:
  Applying contenttypes.0001_initial... OK
  Applying contenttypes.0002_remove_content_type_name... OK
  Applying auth.0001_initial... OK
  Applying auth.0002_alter_permission_name_max_length... OK
  Applying auth.0003_alter_user_email_max_length... OK
  Applying auth.0004_alter_user_username_opts... OK
  Applying auth.0005_alter_user_last_login_null... OK
  Applying auth.0006_require_contenttypes_0002... OK
  Applying auth.0007_alter_validators_add_error_messages... OK
  Applying auth.0008_alter_user_username_max_length... OK
  Applying auth.0009_alter_user_last_name_max_length... OK
  Applying auth.0010_alter_group_name_max_length... OK
  Applying auth.00[11](https://github.com/i-dot-ai/consultation-analyser/actions/runs/8323871782/job/22774332754?pr=17#step:6:12)_update_proxy_permissions... OK
  Applying auth.00[12](https://github.com/i-dot-ai/consultation-analyser/actions/runs/8323871782/job/22774332754?pr=17#step:6:13)_alter_user_first_name_max_length... OK
  Applying consultations.0001_initial... OK
  Applying sessions.0001_initial... OK
System check identified some issues:

WARNINGS:
?: (staticfiles.W004) The directory '/__w/consultation-analyser/consultation-analyser/node_modules/govuk-frontend/dist/govuk/assets' in the STATICFILES_DIRS setting does not exist.
No changes detected

Should we bail on these kinds of warnings? (probably yes?)

@nmenezes0 nmenezes0 force-pushed the feature/36-github-actions branch from 55fa2fa to f74c08e Compare March 18, 2024 09:55
@nmenezes0
Copy link
Contributor Author

We get some warnings from the check:

System check identified some issues:

WARNINGS:
?: (staticfiles.W004) The directory '/__w/consultation-analyser/consultation-analyser/node_modules/govuk-frontend/dist/govuk/assets' in the STATICFILES_DIRS setting does not exist.
Operations to perform:
  Apply all migrations: auth, consultations, contenttypes, sessions
Running migrations:
  Applying contenttypes.0001_initial... OK
  Applying contenttypes.0002_remove_content_type_name... OK
  Applying auth.0001_initial... OK
  Applying auth.0002_alter_permission_name_max_length... OK
  Applying auth.0003_alter_user_email_max_length... OK
  Applying auth.0004_alter_user_username_opts... OK
  Applying auth.0005_alter_user_last_login_null... OK
  Applying auth.0006_require_contenttypes_0002... OK
  Applying auth.0007_alter_validators_add_error_messages... OK
  Applying auth.0008_alter_user_username_max_length... OK
  Applying auth.0009_alter_user_last_name_max_length... OK
  Applying auth.0010_alter_group_name_max_length... OK
  Applying auth.00[11](https://github.com/i-dot-ai/consultation-analyser/actions/runs/8323871782/job/22774332754?pr=17#step:6:12)_update_proxy_permissions... OK
  Applying auth.00[12](https://github.com/i-dot-ai/consultation-analyser/actions/runs/8323871782/job/22774332754?pr=17#step:6:13)_alter_user_first_name_max_length... OK
  Applying consultations.0001_initial... OK
  Applying sessions.0001_initial... OK
System check identified some issues:

WARNINGS:
?: (staticfiles.W004) The directory '/__w/consultation-analyser/consultation-analyser/node_modules/govuk-frontend/dist/govuk/assets' in the STATICFILES_DIRS setting does not exist.
No changes detected

Should we bail on these kinds of warnings? (probably yes?)

Yes, we probably should - will look at that.

@nmenezes0 nmenezes0 merged commit c3f4a88 into main Mar 18, 2024
2 checks passed
@nmenezes0 nmenezes0 deleted the feature/36-github-actions branch March 18, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants